Redesign of the SDAI theme, URGENT!
Rosina Bignall
I have been investigating the structure and styling of the SDAI frontend theme as I try to implement a new SDAI site with a very specific profile.
It is CRAZY and (apologies to the developers) STUPID!!!
- Most of the buttons are not actually buttons, but p's with a whole bunch of inline styling. There is only one actual button on the home page and that is the search button.
- 99% of the link's are not a's but p's again with a whole bunch of sytling or some other kind of element. I'm not totally sure yet, but I'm betting it uses some javascript or something to implement the clicks on those p's or other elements. It SHOULD be using a links! Then it could be indexable and easier (not to mention native) implementation!
- The sections have no id's or classes to uniquely identify them (at least that's how it appears to me so far, I haven't done an in depth study on this yet).
This is ABSOLUTELY stupid. And is probably one of the BIG reasons it is not indexable and difficult to override styling..
- The inline styling makes for tons of unnecessary duplication. Use a style sheet! And id's or classes for things with similar styling!
- The lack of id's or classes not to mention the inline styling make it difficult to override the default styling.
- Buttons should be buttons not p's! They can be styled to look and do what you want, but they should be buttons!
- And using javascript or something to implement clicks that could be easily done by a links is absolutely stupid and makes for more complicated and error prone implementation of something that is native.
I know you are working on some other theme's but if they do the same thing, they will be just as STUPID!